Great opportunity to apply list comprehension (suggestion) #2

New Issue

oekk · 2019-11-17T15:22:42+01:00

oekk commented

2019-11-17 15:22:42 +01:00

In MinimumSkew.py

Conditions met to use list comprehensions:

Creation of a list: positions
Filter of data: if skew[i] == minimum
Iterator: range(0, len(Genome))

With this in mind we can change the following code:

def MinimumSkew(Genome):
    positions = []
    skew = SkewArray(Genome)
    minimum = min(skew)
    for i in range(0, len(Genome)):
        if skew[i] == minimum:
            positions.append(i)
    return positions

for this:

def MinimumSkew(Genome):
    skew = SkewArray(Genome)
    minimum = min(skew)
    return [i for i in range(0, len(Genome)) if skew[i] == minimum]

The "formula" used has the following basic structure:

[expression for item in list if conditional]

which is equivalent to:

for item in list:
    if conditional:
        expression

In [MinimumSkew.py](https://coolneng.duckdns.org/gitea/coolneng/biology-meets-programming/src/branch/master/Code/MinimumSkew.py) Conditions met to use list comprehensions: - Creation of a list: positions - Filter of data: if skew[i] == minimum - Iterator: range(0, len(Genome)) With this in mind we can change the following code: def MinimumSkew(Genome): positions = [] skew = SkewArray(Genome) minimum = min(skew) for i in range(0, len(Genome)): if skew[i] == minimum: positions.append(i) return positions for this: def MinimumSkew(Genome): skew = SkewArray(Genome) minimum = min(skew) return [i for i in range(0, len(Genome)) if skew[i] == minimum] The "formula" used has the following basic structure: ``` [expression for item in list if conditional] ``` which is equivalent to: ``` for item in list: if conditional: expression ```

coolneng commented

2019-11-17 15:55:06 +01:00

That is elegant, thanks!

coolneng referenced this issue from a commit

2019-11-17 15:55:35 +01:00

Refactor MinimumSkew using list comprehension fixes: #2

coolneng closed this issue

2019-11-17 15:55:35 +01:00

Sign in to join this conversation.